use FastAPI test client for testing #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 14, 2024
| username = default_user() | ||
| token = ( | ||
| client.post( | ||
| "/token", | ||
| data={ | ||
| "username": username, | ||
| "password": os.environ.get( | ||
| "AI_PROXY_DEMO_AUTHENTICATION_PASSWORD", username | ||
| "RAGNA_DEMO_AUTHENTICATION_PASSWORD", username |
There was a problem hiding this comment.
This was a driveby since I was looking at this function. After that I greped for the wrong string and found one more usage that I also fixed.
|
|
||
|
|
||
| @pytest.mark.parametrize("database", ["memory", "sqlite"]) |
There was a problem hiding this comment.
Removing the memory test here for two reasons:
- remove memory option for state db #320 will remove it from our special cases. Meaning, this is no longer part of our core API, but rather a special case.
- For some reason, in-memory databases don't play nice with the
TestClient(Documented testing approach does not work for SQLite in-memory instances tiangolo/fastapi#3906). The proposed solution, i.e. usingpoolclass=StaticPooldoes indeed work, but will cause the streaming test to crash with RunTimeError: got Future <Future pending> attached to a different loop when using custom loop in sync fixtures when upgrading from 0.14.2 to 0.15.0 encode/starlette#1315. I figured it wasn't worth the effort to dive any deeper than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title. Documentation is here. This has at least three upsides: