Skip to content

Commit

Permalink
fix: boolean numeric short option (yargs#283)
Browse files Browse the repository at this point in the history
  • Loading branch information
QmarkC committed Jul 20, 2020
1 parent bdc80ba commit 66f094e
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
3 changes: 2 additions & 1 deletion index.ts
Expand Up @@ -333,7 +333,8 @@ function parse (argsInput: ArgsInput, options?: Partial<Options>): DetailedArgum

// current letter is an alphabetic character and next value is a number
if (/[A-Za-z]/.test(letters[j]) &&
/^-?\d+(\.\d*)?(e-?\d+)?$/.test(next)) {
/^-?\d+(\.\d*)?(e-?\d+)?$/.test(next) &&
checkAllAliases(next, flags.bools) === false) {
setArg(letters[j], next)
broken = true
break
Expand Down
20 changes: 20 additions & 0 deletions test/yargs-parser.js
Expand Up @@ -1128,6 +1128,26 @@ describe('yargs-parser', function () {
result.should.have.property('b').that.is.a('boolean').and.is.true // eslint-disable-line
result.should.have.property('_').and.deep.equal([123])
})

// Fixes: https://github.com/yargs/yargs-parser/issues/283
it('should set boolean numeric option, with numeric option at the end of a group', function () {
const result = parser(['-x1'], { boolean: ['x', '1'] })
expect(result).to.have.property('x', true)
expect(result).to.have.property('1', true)
})

it('should set boolean numeric option, with numeric option at the start of a group', function () {
const result = parser(['-1x'], { boolean: ['x', '1'] })
expect(result).to.have.property('x', true)
expect(result).to.have.property('1', true)
})

it('should set boolean numeric option, with numeric option as part of a group', function () {
const result = parser(['-x1b'], { boolean: ['x', '1', 'b'] })
expect(result).to.have.property('x', true)
expect(result).to.have.property('1', true)
expect(result).to.have.property('b', true)
})
})

describe('defaults', function () {
Expand Down

0 comments on commit 66f094e

Please sign in to comment.