Fix mypy errors (results) #8255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Randl
commented
Jun 28, 2022
qiskit/result/mitigation/utils.py
Outdated
| @@ -32,7 +32,7 @@ def z_diagonal(dim, dtype=float): | |||
| return (-1) ** np.mod(parity, 2) | |||
|
|
|||
|
|
|||
| def expval_with_stddev(coeffs: np.ndarray, probs: np.ndarray, shots: int) -> Tuple[float, float]: | |||
| def expval_with_stddev(coeffs: np.ndarray, probs: np.ndarray, shots: int) -> List[float]: | |||
There was a problem hiding this comment.
Possibly instead should return tuple of floats, i.e.,
return expval, calc_stddev
in L59
javabster
added
the
Community PR
1ucian0
added
the
mypy
Randl
commented
Apr 5, 2023
| @@ -122,7 +124,7 @@ def expectation_value( | |||
| diagonal = str2diag(diagonal) | |||
|
|
|||
| # Apply transpose of mitigation matrix | |||
| coeffs = mit_mat.T.dot(diagonal) | |||
| coeffs = mit_mat.T.dot(diagonal) # TODO: won't work if diagonal is Callable or dict? | |||
There was a problem hiding this comment.
The case of diagonal being Callable or dict is not explained anywhere in documentation (even though it is mentioned there) and is not tested. Not sure what it means.
Randl
commented
Apr 5, 2023
| """The device qubits for this mitigator""" | ||
| return self._qubits | ||
| return self._qubits # TODO: cast to tuple or change return type |
There was a problem hiding this comment.
This appears to be just the wrong signature. self._qubits is not necessarily tuple.
Randl
force-pushed
the
mypy-4
branch
2 times, most recently
from
8d9dbde
to
79deca9
Compare
Pull Request Test Coverage Report for Build 5057927442
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8702741555Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
This fixes all the mypy errors in results as for now.