-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version of OpenQASM 3.0 standard library #12387
base: main
Are you sure you want to change the base?
Conversation
This is just a file vendored from the OpenQASM project, but it's been updated since the last time we vendored it to fix a couple of problems. This one is vendored from openqasm/openqasm@4ca1d793833b24a1.
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 9033180578Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a quick question about the link at the beginning of the file.
// OpenQASM 3.0 standard gate library | ||
// | ||
// Vendored from the OpenQASM 3.0 project at | ||
// https://github.com/openqasm/openqasm.git@4ca1d793833b24a1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right link? It leads to a Not Found
message.
Summary
This is just a file vendored from the OpenQASM project, but it's been updated since the last time we vendored it to fix a couple of problems. This one is vendored from openqasm/openqasm@4ca1d793833b24a1.
Details and comments
Close #12167
Actually that issue was about something a little different, but this is the only remnant bit that needs addressing from Qiskit.