Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan dependency problem with urllib3 #1031

Merged
merged 4 commits into from Nov 11, 2020

Conversation

vvilpas
Copy link
Contributor

@vvilpas vvilpas commented Nov 11, 2020

Summary

urllib3 1.26.0 has been released, causing a dependency when installing conan (coming form requests lib).
Here I add urllib3 add as a dependency and constraint it to <1.26 to avoid this problem.

Details and comments

The issue has been already reported to Conan team by some users: conan-io/conan#8041.
Here conan-io/conan#8042 they mention that requests lib version 2.25 (to be released today tomorrow: psf/requests#5654) will be compatible with this urllib3 1.26. In the meantime we can use this ugly fix.

urllib3 1.26.0 has been released, causing a dependency error when installing conan.
Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm not sure of is the pyproject.toml change. But it doesn't hurt since this is just a temporary PR to unblock CI. We should revert this once there is a working combination of urllib3, requests, and conan again.

@vvilpas vvilpas merged commit 8ef3708 into Qiskit:master Nov 11, 2020
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Dec 11, 2020
urllib3 1.26.0 has been released, causing a dependency error when installing conan.
Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Dec 11, 2020
urllib3 1.26.0 has been released, causing a dependency error when installing conan.
Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Jan 25, 2021
urllib3 1.26.0 has been released, causing a dependency error when installing conan.
Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic pushed a commit to chriseclectic/qiskit-aer that referenced this pull request Jan 25, 2021
urllib3 1.26.0 has been released, causing a dependency error when installing conan.
Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants