Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PY36 #1259

Merged
merged 5 commits into from May 24, 2022
Merged

Drop support for PY36 #1259

merged 5 commits into from May 24, 2022

Conversation

waylan
Copy link
Member

@waylan waylan commented May 24, 2022

Python dropped support on 2021-12-23. Our policy (#760) is to drop
support on the next point release after Python does.

Python dropped support on 2021-12-23. Our policy (Python-Markdown#760) is to drop
support on the next point release after Python does.
@waylan waylan added this to the Version 3.4 milestone May 24, 2022
@waylan waylan added the process Discussions regarding policies and development process. label May 24, 2022
@@ -33,7 +31,7 @@ jobs:
- tox-env: py310
python-version: '3.10'
- tox-env: pypy3
python-version: pypy3
python-version: pypy-3.7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wait for the next release of actions/setup-python, it will presumably include the changes in actions/setup-python#349. Then we can exclude the - from the version (like this pypy3.7), which is more consistent with all other version indicators.

Additionally, I wonder if we should perhaps run pypy tests for all supported versions (3.7, 3.8, 3.9).

@waylan waylan added the requires-changes Awaiting updates after a review. label May 24, 2022
@waylan
Copy link
Member Author

waylan commented May 24, 2022

As PEP562 was added in PY37, we can also remove the backport. This should resolve the failing coverage check.

@waylan waylan merged commit cebe1de into Python-Markdown:master May 24, 2022
@waylan waylan deleted the droppy36 branch May 24, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Discussions regarding policies and development process. requires-changes Awaiting updates after a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant