Skip to content

Commit

Permalink
Update CLI to support PyYAML 5.1
Browse files Browse the repository at this point in the history
This should avoid any warnings. We use `unsafe_load` because users may
need to pass in actual Python objects. As this is only available from
the CLI, the user has much worse problems if an attacher can use this
as an attach vector.
  • Loading branch information
waylan committed Mar 14, 2019
1 parent cb47805 commit 937ca75
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/change_log/release-3.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ The following new features have been included in the release:

The following bug fixes are included in the 3.1 release:

* Update CLI to support PyYAML 5.1.
* Overlapping raw HTML matches no longer leave placeholders behind (#458).
* Emphasis patterns now recognize newline characters as whitespace (#783).
* Version format had been updated to be PEP 440 compliant (#736).
Expand Down
14 changes: 11 additions & 3 deletions markdown/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,17 @@
import warnings
import markdown
try:
import yaml
# We use `unsafe_load` because users may need to pass in actual Python
# objects. As this is only available from the CLI, the user has much
# worse problems if an attacher can use this as an attach vector.
from yaml import unsafe_load as yaml_load
except ImportError: # pragma: no cover
import json as yaml
try:
# Fall back to PyYAML <5.1
from yaml import load as yaml_load
except ImportError:
# Fall back to JSON
from json import load as yaml_load

import logging
from logging import DEBUG, WARNING, CRITICAL
Expand Down Expand Up @@ -97,7 +105,7 @@ def parse_options(args=None, values=None):
options.configfile, mode="r", encoding=options.encoding
) as fp:
try:
extension_configs = yaml.load(fp)
extension_configs = yaml_load(fp)
except Exception as e:
message = "Failed parsing extension config file: %s" % \
options.configfile
Expand Down

0 comments on commit 937ca75

Please sign in to comment.