Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function for cubic spline interpolation #3216

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

eslickj
Copy link
Contributor

@eslickj eslickj commented Mar 28, 2024

Summary/Motivation:

This adds an external function for cubic spline interpolation. I couldn't find this functionality in Pyomo, but I may have missed something. This is just a draft. I wanted to see if this is worth finishing. I can finish cleaning this up and adding tests or close it. I need functionality similar to this for pump and fan curves.

Changes proposed in this PR:

  • Add an external function cubic spline interpolation function

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@eslickj eslickj marked this pull request as draft March 28, 2024 22:55
@blnicho blnicho changed the title Add a function for cubic spline interpolation [DRAFT] [WIP] Add a function for cubic spline interpolation Apr 3, 2024
@mrmundt
Copy link
Contributor

mrmundt commented Apr 9, 2024

We discussed in the weekly dev call and expressed that this PR sounds interesting / useful. If you have time, @eslickj , please feel free to push forward with it.

@eslickj
Copy link
Contributor Author

eslickj commented Apr 11, 2024

@mrmundt, Thanks! I think it's all there and functioning properly. I'll write tests as I have time.

@eslickj
Copy link
Contributor Author

eslickj commented May 14, 2024

@mrmundt, I added tests.

@eslickj eslickj marked this pull request as ready for review May 15, 2024 09:59
@eslickj eslickj changed the title [WIP] Add a function for cubic spline interpolation Add a function for cubic spline interpolation May 15, 2024
@mrmundt mrmundt marked this pull request as draft May 15, 2024 15:24
@mrmundt mrmundt marked this pull request as ready for review May 15, 2024 15:24
@mrmundt
Copy link
Contributor

mrmundt commented May 21, 2024

@eslickj - The failing test is indicating that you have a missing __init__.py file. Please add that file in and ideally the tests should start passing!

@eslickj
Copy link
Contributor Author

eslickj commented May 22, 2024

@mrmundt, I added the file.

@blnicho blnicho requested a review from Robbybp May 28, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants