Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we don't loop trying to write to a channel thats not connected (fix 100% CPU) #419

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

ensure we don't loop trying to write to a channel thats not connected (fix 100% CPU) #419

wants to merge 21 commits into from

Commits on Sep 11, 2023

  1. ensure we don't keep trying to write to a channel thats not connected

    @djay
    djay committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2c82632 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. add test

    @djay
    djay committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    26c3855 View commit details
    Browse the repository at this point in the history

  2. use writable to avoid loop instead

    @djay
    djay committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1b9e35c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. add test for loop due to getpearname failing

    @djay
    djay committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    04056ab View commit details
    Browse the repository at this point in the history

  2. make test shutdown right after accept

    @djay
    djay committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5130bec View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. try keepalive to make connection close quickly

    @djay
    djay committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ea3cb3a View commit details
    Browse the repository at this point in the history

  2. simplify test

    @djay
    djay committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a71f5c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. reproduce but with 0 sleep.

    @djay
    djay committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    deea18a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. reproduces loop but doesn't explain how data got written

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f95d396 View commit details
    Browse the repository at this point in the history

  2. reproduce loop with send continue but fake EWOULDBLOCK

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    fb5f7e9 View commit details
    Browse the repository at this point in the history

  3. reproduce loop with request error quick close.

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    23e7b05 View commit details
    Browse the repository at this point in the history

  4. comment out parts of test not used

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    9c56472 View commit details
    Browse the repository at this point in the history

  5. fix looping

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    97620b3 View commit details
    Browse the repository at this point in the history

  6. remove test that didn't work

    @djay
    djay committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    a3fda8c View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. clean up test and make pass

    @djay
    djay committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    73a25c9 View commit details
    Browse the repository at this point in the history

  2. fix comments

    @djay
    djay committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f078e45 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. also fix maintenance not cleaning up broken channel

    @djay
    djay committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ae1bf12 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. change fix to mark when closed and always end loop

    @djay
    djay committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    fcb35a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into write_when_not_connected_loop

    @djay
    djay committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6ecfe4d View commit details
    Browse the repository at this point in the history

  3. add git ignore

    @djay
    djay committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cb1b196 View commit details
    Browse the repository at this point in the history

  4. add extra tests to show the loop behaviour

    @djay
    djay committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b33848b View commit details
    Browse the repository at this point in the history