Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "master" to "main" #378

Closed
wants to merge 3 commits into from
Closed

rename "master" to "main" #378

wants to merge 3 commits into from

Conversation

jvanasco
Copy link
Contributor

@jvanasco
Copy link
Contributor Author

The following will need maintainers to implement/address:

@mmerickel
Copy link
Member

Yeah we need to drop py27,py34,py35,py36, and add py39,py310,py311.

@jvanasco
Copy link
Contributor Author

Redefining the supported versions may be better done in a separate PR, then followed by a rebase or similar of this PR.

The following things need to be handle for that change:

  • /demo/demo.py defines "PY3" and has a docstring
    • ease testing py2 and py3 in same directory

    • i think this may still be useful for serial test runs under a single platform, though I am not sure.
  • the nosetests xml files will need to be generated for newer pythons. i don't know how to do that.
  • /pyproject.toml needs the versions updated
  • /setup.cfg needs the classifiers and python_requires updated; the install_requires might require pyramid2
  • /src/pyramid_debugtoolbar/compat.py should eventually go, but a first step would be dropping the PY3/PY2 blocks
  • /src/pyramid_debugtoolbar/panels/request_vars.py has a docstring about PY2. might be okay to drop, but might be good to leave for anyone upgrading to PY3
  • /src/pyramid_debugtoolbar/repr.py has py2_string_repr looks safe to drop; along with some blocks of PY3 from compat
  • /tests/test_auth.py test_unauthenticated worked around a lack of "assertIsNone` in Py26; can be upgraded
  • /tests/test_panels/test_request_vars.py - some PY3 blocks
  • /tests/test_panels/test_session.py - some PY3 blocks
  • /tests/test_panels/test_session.py test_sorting_fatal has a skipUnless for Py3.
  • /tests/test_panels/test_sqla.py - Note: the <pre> styles are different on the Py2 and Py3 libraries
  • /tox.ini suggests this isn't run against pyramid2

# "selenium.isElementPresent(\"//table[@id='pSqlaTable']\")",
# "30000")
# result = browser.get_text('css=#pDebugWindow .pDebugPanelTitle h3')
# self.assertEqual(result, 'SQL Explained')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mess losing all of this indentation in the comments.

@mmerickel
Copy link
Member

My current plan is to drop unsupported versions and fix CI before looking at this PR. Likely will end up closing this instead of merging it. Thank you for all of the notes in your previous comment which I'll double check as I go through that.

@mmerickel mmerickel closed this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants