docs: refresh ZODB wiki tutorial #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix applied in this commit: Pylons/pyramid-cookiecutter-starter@8b139f6
- Use 'pyproject.toml' rather than 'setup.py', 'pytest.ini', '.coveragerg'. - Drop 'CHANGES.txt': implementing that in 'pyproject.toml' is a distraction. - Convert README to Markdown.
- Describe 'pyproject.toml' usage (replacing 'setup.py', 'pytest.ini', '.coveragerc'). - Document the new PyPA-blessed build process.
mmerickel
requested changes
Feb 7, 2024
There was a problem hiding this comment.
- I caught a missed reference to setup.py in the design chapter.
- In definingviews I caught
We need to add a dependency on the docutils package to our tutorial package's pyproject.toml file by assigning this dependency to the requires parameter in the setup() function.referencing thesetup()function. - In tests chapter I caught several references to
pytest.iniand.coveragerc. Might want to pull some of that language from here if it's helpful. - We had similar but different language around distributing your application. I think we should combine the good from both.
|
I pushed a version that merges things together for |
|
And tweaks to installation.rst for wiki2 here a31db99 |
|
@mmerickel I've cleaned up the remaining |
mmerickel
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendered: https://pylons--3751.org.readthedocs.build/projects/pyramid/en/3751/tutorials/wiki/index.html