Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade handler #684

Merged
merged 18 commits into from Jul 28, 2022
Merged

Upgrade handler #684

merged 18 commits into from Jul 28, 2022

Conversation

vuong177
Copy link
Contributor

Description

  • Upgrade handler for SDK 46.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@nghuyenthevinh2000 nghuyenthevinh2000 mentioned this pull request Jul 26, 2022
Closed
3 tasks
@faddat
Copy link
Contributor

faddat commented Jul 26, 2022

Hey guys, pls don't forget to set the store key for the ephocs module to nil -- iirc that's the right way to remove a module. I think. You may wanna double check on that.

Thanks!

@faddat
Copy link
Contributor

faddat commented Jul 26, 2022 •
edited

As you work on this, recommend that you reference and contribute to this document:

@faddat
Copy link
Contributor

faddat commented Jul 26, 2022

Also check out the release nodes please:

https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.0

@vuong177 vuong177 marked this pull request as ready for review July 27, 2022 15:26
faddat
faddat approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STYLE POINTS, FOR UPGRADE.SH

good work Hieu

mustafapylons
mustafapylons reviewed Jul 27, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few typos, otherwise code is good.

app/upgrade/fork.go Outdated Show resolved Hide resolved
app/upgrade/fork.go Outdated Show resolved Hide resolved
mustafapylons
mustafapylons approved these changes Jul 27, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@faddat faddat merged commit 43abf26 into main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@mustafapylons mustafapylons mustafapylons approved these changes

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

@faisalnaveedRNS faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vuong177 @faddat @mustafapylons @hieuvubk