Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v46 #576

Closed
wants to merge 22 commits into from
Closed

v46 #576

wants to merge 22 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 3, 2022

Description

The cosmos sdk has bumped tendermint down to 34 successfully, and this branch is based on the first public release of that work, tracked to be merged into cosmos-sdk v46 and released as final. This work is accompanied by version 46 upgrades to ibc-go v4 and CosmWasm's wasmd v0.28.0

cosmos/ibc-go#1653

This branch is "ready to ship" to a testnet as soon as it greenifies.

I don't think we'll add cw on this release, though that can be a topic for today's call.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MikeSofaer
Copy link
Collaborator

I thought you were boycotting gitpod

@faddat
Copy link
Contributor Author

faddat commented Jun 3, 2022

gitpod team members reached out to me, and they've removed themselves from the madness letter.

@MikeSofaer
Copy link
Collaborator

legendary

@faddat faddat changed the title notional-updates v46 Jun 7, 2022
@faddat faddat mentioned this pull request Jun 7, 2022
19 tasks
@vuong177
Copy link
Contributor

vuong177 commented Jul 3, 2022

@faddat, how about ics-721-nft-transfer ? Should we make pylons NFT can be transfer over IBC ?

@faddat
Copy link
Contributor Author

faddat commented Jul 5, 2022

not in this build, I think

@nghuyenthevinh2000
Copy link
Contributor

nghuyenthevinh2000 commented Jul 5, 2022

I need to get #611 done first because it is related to proto generation as well. Need to convert from sdk.Dec to sdk.Int in proto so as to be compatible with math.Int. v46 has largely moved to math.Int.

starport generate proto-go cannot generate sedly.

I place math-conversion here: notional-labs#2

@faddat
Copy link
Contributor Author

faddat commented Jul 5, 2022

@nghuyenthevinh2000 hey, so I pure-merged your work here, so that we can work from this single branch. Thank you!

@faddat faddat closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants