Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map received applied_tags to int #1817

Merged
merged 4 commits into from Dec 3, 2022
Merged

fix: map received applied_tags to int #1817

merged 4 commits into from Dec 3, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Dec 3, 2022

Summary

Solves an issue where Thread.applied_tags returns an empty list no matter how many tags are applied because the IDs stored are of different variable types.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Dec 3, 2022
@Dorukyum Dorukyum requested a review from a team as a code owner December 3, 2022 15:44
@Dorukyum Dorukyum self-assigned this Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1817 (a608704) into master (6fc350f) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1817   +/-   ##
=======================================
  Coverage   33.21%   33.21%           
=======================================
  Files          96       96           
  Lines       18657    18657           
=======================================
  Hits         6196     6196           
  Misses      12461    12461           
Flag Coverage Δ
macos-latest-3.10 33.19% <0.00%> (ø)
macos-latest-3.11 33.19% <0.00%> (ø)
macos-latest-3.8 33.20% <0.00%> (ø)
macos-latest-3.9 33.20% <0.00%> (ø)
ubuntu-latest-3.10 33.19% <0.00%> (ø)
ubuntu-latest-3.11 33.19% <0.00%> (ø)
ubuntu-latest-3.8 33.20% <0.00%> (ø)
ubuntu-latest-3.9 33.20% <0.00%> (ø)
windows-latest-3.10 33.19% <0.00%> (ø)
windows-latest-3.11 33.19% <0.00%> (ø)
windows-latest-3.8 33.20% <0.00%> (ø)
windows-latest-3.9 33.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/threads.py 30.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc350f...a608704. Read the comment docs.

@BobDotCom BobDotCom merged commit 7b0f851 into master Dec 3, 2022
@Lulalaby Lulalaby deleted the int-applied_tags branch December 3, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants