Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): fix new issue with bridge_commands attribute #1815

Merged
merged 4 commits into from Dec 3, 2022

Conversation

Middledot
Copy link
Member

fix #1808

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot requested review from a team as code owners December 3, 2022 02:19
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1815 (ee1b156) into master (49387eb) will not change coverage.
The diff coverage is 0.00%.

❗ Current head ee1b156 differs from pull request most recent head 94fc53c. Consider uploading reports for the commit 94fc53c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1815   +/-   ##
=======================================
  Coverage   33.21%   33.21%           
=======================================
  Files          96       96           
  Lines       18657    18657           
=======================================
  Hits         6196     6196           
  Misses      12461    12461           
Flag Coverage Δ
macos-latest-3.10 33.19% <0.00%> (ø)
macos-latest-3.11 33.19% <0.00%> (ø)
macos-latest-3.8 33.20% <0.00%> (ø)
macos-latest-3.9 33.20% <0.00%> (ø)
ubuntu-latest-3.10 33.19% <0.00%> (ø)
ubuntu-latest-3.11 33.19% <0.00%> (ø)
ubuntu-latest-3.8 33.20% <0.00%> (ø)
ubuntu-latest-3.9 33.20% <0.00%> (ø)
windows-latest-3.10 33.19% <0.00%> (ø)
windows-latest-3.11 33.19% <0.00%> (ø)
windows-latest-3.8 33.20% <0.00%> (ø)
windows-latest-3.9 33.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/cog.py 34.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49387eb...94fc53c. Read the comment docs.

Nzii3
Nzii3 previously approved these changes Dec 3, 2022
Lulalaby
Lulalaby previously approved these changes Dec 3, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) December 3, 2022 05:28
@BobDotCom BobDotCom changed the title feat(ext.bridge): fix bridge_commands attribute again feat(ext.bridge): fix new issue with bridge_commands attribute Dec 3, 2022
@BobDotCom BobDotCom dismissed stale reviews from Lulalaby and Nzii3 via 953fcd1 December 3, 2022 14:59
@BobDotCom BobDotCom changed the title feat(ext.bridge): fix new issue with bridge_commands attribute fix(ext.bridge): fix new issue with bridge_commands attribute Dec 3, 2022
@BobDotCom BobDotCom merged commit 9db16eb into Pycord-Development:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Bot' object has no attribute '_bridge_commands'
4 participants