Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix attribute error in select #1814

Merged
merged 3 commits into from Dec 2, 2022
Merged

fix: Fix attribute error in select #1814

merged 3 commits into from Dec 2, 2022

Conversation

ItsRqtl
Copy link
Contributor

@ItsRqtl ItsRqtl commented Dec 1, 2022 •
edited by Lulalaby

No description provided.

@ItsRqtl ItsRqtl requested a review from a team as a code owner December 1, 2022 19:02
plun1331
plun1331 previously requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite the right fix, instead __item_repr_attributes__ (above __init__ should have select_type changed to just type as that's already an attribute/property

@ItsRqtl ItsRqtl requested a review from plun1331 December 2, 2022 16:52
@Lulalaby Lulalaby enabled auto-merge (squash) December 2, 2022 16:53
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority python labels Dec 2, 2022
@Lulalaby Lulalaby modified the milestone: v2.4 Dec 2, 2022
@Lulalaby Lulalaby changed the title fix: add missing select_type in Select fix: Fix attribute error in select Dec 2, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) December 2, 2022 16:55
@Lulalaby Lulalaby merged commit 49387eb into Pycord-Development:master Dec 2, 2022
@ItsRqtl ItsRqtl deleted the fix branch December 2, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

Assignees

@ItsRqtl ItsRqtl

Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ItsRqtl @Lulalaby @plun1331