Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for nsfw commands #1775

Merged
merged 11 commits into from Nov 10, 2022

Conversation

NeloBlivion
Copy link
Member

Summary

Implements discord/discord-api-docs#5617
Officially releases on the 16th, but it's seemingly functional.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@NeloBlivion NeloBlivion requested review from a team as code owners November 10, 2022 14:18
@Lulalaby
Copy link
Member

image

@Lulalaby Lulalaby added priority: low Low Priority feature Implements a feature ext.bridge Relating to ext.bridge upcoming discord feature Involves a feature not yet fully released by Discord labels Nov 10, 2022
@Lulalaby Lulalaby marked this pull request as draft November 10, 2022 14:22
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1775 (de35bda) into master (4fb327c) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
- Coverage   33.14%   33.12%   -0.03%     
==========================================
  Files          96       96              
  Lines       18514    18529      +15     
==========================================
+ Hits         6137     6138       +1     
- Misses      12377    12391      +14     
Flag Coverage Δ
macos-latest-3.10 33.11% <12.50%> (-0.03%) ⬇️
macos-latest-3.11 33.11% <12.50%> (-0.03%) ⬇️
macos-latest-3.8 33.12% <12.50%> (-0.03%) ⬇️
macos-latest-3.9 33.12% <12.50%> (-0.03%) ⬇️
ubuntu-latest-3.10 33.11% <12.50%> (-0.03%) ⬇️
ubuntu-latest-3.11 33.11% <12.50%> (-0.03%) ⬇️
ubuntu-latest-3.8 33.12% <12.50%> (-0.03%) ⬇️
ubuntu-latest-3.9 33.12% <12.50%> (-0.03%) ⬇️
windows-latest-3.10 33.11% <12.50%> (-0.03%) ⬇️
windows-latest-3.11 33.11% <12.50%> (-0.03%) ⬇️
windows-latest-3.8 33.12% <12.50%> (-0.03%) ⬇️
windows-latest-3.9 33.12% <12.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/bot.py 18.31% <ø> (ø)
discord/commands/core.py 17.99% <0.00%> (-0.18%) ⬇️
discord/commands/permissions.py 23.33% <25.00%> (-2.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb327c...de35bda. Read the comment docs.

@Lulalaby Lulalaby added this to the v2.3 milestone Nov 10, 2022
@BobDotCom BobDotCom marked this pull request as ready for review November 10, 2022 19:35
@BobDotCom BobDotCom enabled auto-merge (squash) November 10, 2022 19:35
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is working on the api, so let's go ahead and get it merged now.

Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BobDotCom BobDotCom merged commit df85b81 into Pycord-Development:master Nov 10, 2022
@NeloBlivion NeloBlivion deleted the patch-29 branch November 21, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext.bridge Relating to ext.bridge feature Implements a feature priority: low Low Priority upcoming discord feature Involves a feature not yet fully released by Discord
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants