Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin cchardet version and add qualifiers #1726

Merged
merged 1 commit into from Oct 25, 2022
Merged

Pin cchardet version and add qualifiers #1726

merged 1 commit into from Oct 25, 2022

Conversation

BobDotCom
Copy link
Member

Summary

cchardet does not support python 3.10, see PyYoshi/cChardet#78.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom added priority: low Low Priority status: awaiting review Awaiting review from a maintainer dependencies Pull requests that update a dependency file labels Oct 25, 2022
@BobDotCom BobDotCom requested a review from a team as a code owner October 25, 2022 13:32
@BobDotCom BobDotCom self-assigned this Oct 25, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) October 25, 2022 13:33
@BobDotCom BobDotCom merged commit f89453e into master Oct 25, 2022
@Lulalaby Lulalaby deleted the fix-cchardet branch October 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

Assignees

@BobDotCom BobDotCom

Labels
dependencies Pull requests that update a dependency file priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BobDotCom @Lulalaby @plun1331