Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message send flags #1723

Merged
merged 3 commits into from Oct 23, 2022

Conversation

Dorukyum
Copy link
Member

Summary

Closes #1722 by making sure that flags is always an integer and not an instance of flag_value.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Oct 23, 2022
@Dorukyum Dorukyum self-assigned this Oct 23, 2022
@Dorukyum Dorukyum requested a review from a team as a code owner October 23, 2022 15:19
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #1723 (3d8cf3d) into master (92de03a) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          96       96           
  Lines       18414    18414           
=======================================
  Hits         6113     6113           
  Misses      12301    12301           
Flag Coverage Δ
pytest 33.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/abc.py 22.82% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92de03a...3d8cf3d. Read the comment docs.

@Dorukyum Dorukyum added priority: high High Priority and removed priority: medium Medium Priority labels Oct 23, 2022
@plun1331 plun1331 enabled auto-merge (squash) October 23, 2022 16:17
@Lulalaby Lulalaby merged commit 0de0652 into Pycord-Development:master Oct 23, 2022
@Dorukyum Dorukyum deleted the fix-message-send-flags branch October 23, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Channel unexpected error
3 participants