Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 655 NotRequired #1705

Merged
merged 10 commits into from Oct 21, 2022
Merged

Implement PEP 655 NotRequired #1705

merged 10 commits into from Oct 21, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Reference: https://peps.python.org/pep-0655
Note: https://peps.python.org/pep-0655/#usage-in-python-3-11

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom self-assigned this Oct 16, 2022
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #1705 (5c445b0) into master (ebc9b28) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5c445b0 differs from pull request most recent head e7850a4. Consider uploading reports for the commit e7850a4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
+ Coverage   33.24%   33.25%   +0.01%     
==========================================
  Files          95       95              
  Lines       18426    18429       +3     
==========================================
+ Hits         6125     6128       +3     
  Misses      12301    12301              
Flag Coverage Δ
pytest 33.25% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/types/channel.py 100.00% <100.00%> (ø)
discord/types/components.py 100.00% <100.00%> (ø)
discord/types/embed.py 100.00% <100.00%> (ø)
discord/types/interactions.py 99.27% <100.00%> (-0.03%) ⬇️
discord/types/message.py 98.87% <100.00%> (+0.01%) ⬆️
discord/types/role.py 100.00% <100.00%> (ø)
discord/types/sticker.py 100.00% <100.00%> (ø)
discord/types/threads.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba56ef...e7850a4. Read the comment docs.

@BobDotCom BobDotCom marked this pull request as ready for review October 20, 2022 22:22
@BobDotCom BobDotCom enabled auto-merge (squash) October 20, 2022 22:36
@BobDotCom BobDotCom requested review from a team, FrostByte266, WhoIsConch and Middledot and removed request for a team October 21, 2022 02:25
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby merged commit a8d903c into master Oct 21, 2022
@Lulalaby Lulalaby deleted the pep-655 branch October 21, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants