Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors that will occur in python3.11 #1680

Merged
merged 1 commit into from Oct 14, 2022
Merged

Fix errors that will occur in python3.11 #1680

merged 1 commit into from Oct 14, 2022

Conversation

Youtong0826
Copy link
Contributor

@Youtong0826 Youtong0826 commented Oct 8, 2022

Summary

Fix errors that will occur in python3.11 and decorator not use function name

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

discord/utils.py Outdated Show resolved Hide resolved
BobDotCom added a commit that referenced this pull request Oct 9, 2022
#1680 states that some functionality was broken with python 3.11, so running 3.11 in CI should help find any possible issues
BobDotCom
BobDotCom previously approved these changes Oct 9, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) October 9, 2022 22:20
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority labels Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e4aa8e2). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 311cda2 differs from pull request most recent head 802cf80. Consider uploading reports for the commit 802cf80 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1680   +/-   ##
=========================================
  Coverage          ?   33.25%           
=========================================
  Files             ?       95           
  Lines             ?    18412           
  Branches          ?        0           
=========================================
  Hits              ?     6123           
  Misses            ?    12289           
  Partials          ?        0           
Flag Coverage Δ
pytest 33.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/utils.py 31.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4aa8e2...802cf80. Read the comment docs.

@BobDotCom BobDotCom merged commit 9b7f5c6 into Pycord-Development:master Oct 14, 2022
@Nzii3 Nzii3 mentioned this pull request Nov 29, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants