Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep 517 #1668

Merged
merged 24 commits into from Oct 8, 2022
Merged

Pep 517 #1668

merged 24 commits into from Oct 8, 2022

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Oct 4, 2022

Summary

This PR implements PEP 517 support
Closes #1660

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom added priority: medium Medium Priority status: in progress Work in Progess labels Oct 4, 2022
@BobDotCom BobDotCom self-assigned this Oct 4, 2022
@BobDotCom BobDotCom added this to the v2.3 milestone Oct 4, 2022
This is needed because the setuptools_scm automatically adds all files tracked by git
This file remains in order to support older build environments, but only needs a single setup() call with no parameters
This now supports the new versioning system with setuptools_scm
@BobDotCom BobDotCom marked this pull request as ready for review October 5, 2022 16:32
Lulalaby
Lulalaby previously approved these changes Oct 5, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) October 5, 2022 16:33
@BobDotCom
Copy link
Member Author

Don't want to merge this yet, we're releasing a patch version today so let's merge after that to keep the history cleaner

@BobDotCom BobDotCom enabled auto-merge (squash) October 6, 2022 02:51
@BobDotCom BobDotCom enabled auto-merge (squash) October 6, 2022 13:56
@BobDotCom BobDotCom merged commit 587874c into master Oct 8, 2022
@Middledot Middledot deleted the pep-517 branch October 8, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority status: in progress Work in Progess
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PEP 517 Support
3 participants