Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to add debug warning to catch deprecated perms v1 usage until v2 perms are implemented #1301

Merged
merged 1 commit into from Apr 27, 2022

Conversation

krittick
Copy link
Contributor

Summary

This adds logic to catch the HTTPException that occurs when the library tries to submit v1 permissions to the now-deprecated /applications/{application.id}/guilds/{guild.id}/commands/permissions endpoint.

The only change made is to throw a warning in the debug log instead of an unhandled exception.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added bug Something isn't working priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge with squash labels Apr 27, 2022
@krittick krittick added this to the v2.0 milestone Apr 27, 2022
@krittick krittick self-assigned this Apr 27, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 27, 2022
@krittick krittick merged commit 22d9c92 into Pycord-Development:master Apr 27, 2022
v2.0 automation moved this from In progress to Done Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. priority: high High Priority
Projects
Status: No status
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant