Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Message.edit type hinting overload and remove resulting redundant overloads #1299

Merged
merged 2 commits into from Apr 28, 2022
Merged

Update Message.edit type hinting overload and remove resulting redundant overloads #1299

merged 2 commits into from Apr 28, 2022

Conversation

krittick
Copy link
Contributor

Summary

This updates the Message.edit overload to use the full method signature. As a result, the other two overloads for the method are made redundant and were removed.

Without this change, the following typing error occurs:

image

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 27, 2022
@krittick krittick added this to the v2.0 milestone Apr 27, 2022
@krittick krittick self-assigned this Apr 27, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 27, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) April 27, 2022 21:02
@Lulalaby Lulalaby merged commit 82350e3 into Pycord-Development:master Apr 28, 2022
v2.0 automation moved this from In progress to Done Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants