Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None check for check_guilds #1291

Merged
merged 2 commits into from Apr 27, 2022
Merged

None check for check_guilds #1291

merged 2 commits into from Apr 27, 2022

Conversation

freemanovec
Copy link
Contributor

Summary

check_guilds has been marked as optional, but no None check was being done causing TypeError: unsupported operand type(s) for +: 'bool' and 'list' when passing None to check_guilds

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (rebase) April 24, 2022 13:30
@Lulalaby
Copy link
Member

@krittick what do you think.
What we gonna do with this?

@Lulalaby Lulalaby merged commit 7e574cb into Pycord-Development:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants