Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Embed.fields to always return a list #1287

Merged
merged 5 commits into from Apr 24, 2022
Merged

Change Embed.fields to always return a list #1287

merged 5 commits into from Apr 24, 2022

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Apr 24, 2022 •
edited

Summary

  • Changes Embed.fields to always return a list.
  • Simplifies how multiple field related things are handled internally

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick assigned krittick and unassigned krittick Apr 24, 2022
@krittick krittick self-requested a review April 24, 2022 00:26
@krittick krittick added the bug Something isn't working label Apr 24, 2022
@krittick krittick added this to the v2.0 milestone Apr 24, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 24, 2022
krittick
krittick previously approved these changes Apr 24, 2022
View reviewed changes
@krittick
Copy link
Contributor

Good PR.

@krittick krittick enabled auto-merge (squash) April 24, 2022 00:37
@krittick krittick disabled auto-merge April 24, 2022 00:37
@krittick krittick enabled auto-merge (squash) April 24, 2022 00:37
@krittick krittick merged commit 223616f into Pycord-Development:master Apr 24, 2022
v2.0 automation moved this from In progress to Done Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@plun1331 plun1331

Labels
bug Something isn't working
Projects
Pycord Releases
Status: No status
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plun1331 @krittick @Lulalaby