Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context.me returning ClientUser when guilds intent is absent #1286

Merged
merged 1 commit into from Apr 24, 2022
Merged

Context.me returning ClientUser when guilds intent is absent #1286

merged 1 commit into from Apr 24, 2022

Conversation

ashdouble
Copy link
Contributor

@ashdouble ashdouble commented Apr 23, 2022

Summary

In discord.ext.commands.Context, when the guilds intent is absent, self.guild will but self.guild.me will be None. Adding that to the cases where self.me() falls back on returning self.bot user instead.

I don't know of any open issues relevant to this change; the simple test was invoking the default help command with and without the guilds intent.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature Merge with squash labels Apr 24, 2022
@krittick krittick added this to the v2.0 milestone Apr 24, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 24, 2022
@krittick krittick enabled auto-merge (squash) April 24, 2022 00:17
@krittick krittick merged commit 26f48e3 into Pycord-Development:master Apr 24, 2022
v2.0 automation moved this from In progress to Done Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: No status
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants