Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext.pages] Hotfix to make PaginatorMenu use interaction routes for updates #1267

Merged
merged 1 commit into from Apr 15, 2022
Merged

Conversation

krittick
Copy link
Contributor

Summary

This updates PaginatorMenu to pass the Interaction instance in its callback to Paginator.update(), which now also accepts an optional interaction parameter. This matches the changes in #1227 that were implemented for Paginator.goto_page()

Fixes #1265 - tested changes with both Paginator.respond() and Paginator.send() paths and both now work as expected.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

…dating messages, matching the recent changes made by #1227

fixes #1265
@krittick krittick added bug Something isn't working bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages labels Apr 15, 2022
@krittick krittick added this to the v2.0 milestone Apr 15, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 15, 2022
@krittick krittick self-assigned this Apr 15, 2022
@krittick krittick merged commit 9b3618a into Pycord-Development:master Apr 15, 2022
v2.0 automation moved this from In progress to Done Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages
Projects
Status: No status
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Paginator Groups Update The Wrong Command
1 participant