Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert interaction.data["guild_id"] to int in the KeyError fallback within process_application_commands #1262

Merged
merged 6 commits into from Apr 17, 2022

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Apr 15, 2022

Fixes the KeyError fallback in process_application_commands to actually function.

Summary

If an application command can't be found by its interaction ID, there's a fallback that attempts to find it by checking the command name and its guild_ids if they are set. However, the guild_id in interaction.data is a string while SlashCommand.guild_ids is a list of integers and so this would always fail, further resulting in commands being unregistered.

image
image

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Fixes the KeyError fallback; before this fix, this expression would always return False.
@NeloBlivion
Copy link
Member Author

Test: Got ctx.interaction.data from a slash-based eval and used its data to emulate the check used in bot.py

image

discord/bot.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby enabled auto-merge (squash) April 15, 2022 17:42
@Lulalaby Lulalaby merged commit ea69bf5 into Pycord-Development:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants