Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PartialMessage.edit() setting view as None even if it's not passed #1256

Merged
merged 1 commit into from Apr 12, 2022
Merged

Fix PartialMessage.edit() setting view as None even if it's not passed #1256

merged 1 commit into from Apr 12, 2022

Conversation

argo0n
Copy link
Contributor

@argo0n argo0n commented Apr 12, 2022

Summary

Fixes #1255 , where running PartialMessage.edit() will cause the view to be removed even if view was not passed.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (squash) April 12, 2022 13:19
@Lulalaby Lulalaby disabled auto-merge April 12, 2022 13:19
@Lulalaby Lulalaby enabled auto-merge April 12, 2022 13:19
@Lulalaby Lulalaby merged commit b099fa6 into Pycord-Development:master Apr 12, 2022
@argo0n
Copy link
Contributor Author

argo0n commented Apr 29, 2022

Hi, I'm currently on the master branch and this issue is happening again.

@argo0n
Copy link
Contributor Author

argo0n commented Apr 29, 2022

Using the same reproduction code in #1255 will reflect the same result again, I'm not sure if I should open a new issue

@argo0n
Copy link
Contributor Author

argo0n commented Apr 29, 2022 •
edited

Never mind, uninstalling and reinstalling Pycord fixed it again. 😵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Middledot approved these changes

@krittick krittick Awaiting requested review from krittick

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View is removed in PartialMessage.edit() even if it is not passed
3 participants
@argo0n @Lulalaby @Middledot