Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jump_url property to channels #1254

Merged
merged 4 commits into from Apr 12, 2022
Merged

Add jump_url property to channels #1254

merged 4 commits into from Apr 12, 2022

Conversation

Ombucha
Copy link
Contributor

@Ombucha Ombucha commented Apr 12, 2022

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick
Copy link
Contributor

Please update to use double quotes in your f-strings (matches our linting requirements). Otherwise happy to approve after that change is made.

@Ombucha
Copy link
Contributor Author

Ombucha commented Apr 12, 2022

@krittick I have made the requested changes.

@krittick krittick added status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Apr 12, 2022
@krittick krittick added this to the v2.0 milestone Apr 12, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 12, 2022
@krittick krittick merged commit 3ad67fe into Pycord-Development:master Apr 12, 2022
v2.0 automation moved this from In progress to Done Apr 12, 2022
@Ombucha Ombucha deleted the patch-2 branch April 12, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
Status: No status
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants