Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridge] Fix conversion exception #1250

Merged
merged 2 commits into from Apr 18, 2022
Merged

[bridge] Fix conversion exception #1250

merged 2 commits into from Apr 18, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Fixes #1248
Untested

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 11, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Apr 11, 2022
@BobDotCom BobDotCom added this to In progress in v2.0 via automation Apr 11, 2022
@BobDotCom BobDotCom self-assigned this Apr 11, 2022
Lulalaby
Lulalaby previously approved these changes Apr 11, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) April 11, 2022 17:03
@EmreTech
Copy link
Contributor

Just a suggestion: you might wanna clarify in the title of this PR or description or somewhere that this is a fix for ext.bridge

@Dorukyum Dorukyum changed the title Fix conversion exception [bridge] Fix conversion exception Apr 12, 2022
@Lulalaby Lulalaby merged commit b6cad66 into master Apr 18, 2022
v2.0 automation moved this from In progress to Done Apr 18, 2022
@Lulalaby Lulalaby deleted the fix-conversion-exc branch June 9, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

BridgeOption not raising BadArgument when conversion fails
4 participants