Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt_idx to scheduler config if not assigned by user #11247

Merged
merged 7 commits into from Jan 4, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 23, 2021

What does this PR do?

This is required for #10249 since we need to pass in optimizer_idx in the new hook.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @rohitgr7

@rohitgr7 rohitgr7 added this to the 1.6 milestone Dec 23, 2021
pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
pytorch_lightning/core/optimizer.py Show resolved Hide resolved
pytorch_lightning/core/optimizer.py Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from carmocca January 3, 2022 21:40
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

pytorch_lightning/core/optimizer.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 3, 2022
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 3, 2022 22:18
@rohitgr7 rohitgr7 merged commit 98ea79b into master Jan 4, 2022
@rohitgr7 rohitgr7 deleted the enhance/sched_opt_idx branch January 4, 2022 05:57
rohitgr7 added a commit that referenced this pull request Jan 4, 2022
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lr scheduler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants