Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWA LR scheduler not being stepped #12446

Merged
merged 4 commits into from Mar 27, 2022

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Mar 24, 2022

What does this PR do?

Fixes the stochastic weight averaging (SWA) LR scheduler not being stepped. This was broken in #11247, specifically here where a scheduler is no longer stepped if the opt_idx is None: https://github.com/PyTorchLightning/pytorch-lightning/pull/11247/files#diff-ab48e8df50bc4933f169ead5982b38d36f21250a013c9aae7c4974968de43b35L471-L472

This was picked up by my test changes in #9938 and I added a fix there, but it doesn't look like that PR is going to be merged for 1.6.0, so I thought it would be good to fix this separately to avoid a regression in 1.6.0.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • (not needed, bug hasn't been released AFAIK) Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added bug Something isn't working callback: swa labels Mar 25, 2022
@carmocca carmocca added this to the 1.6 milestone Mar 25, 2022
@carmocca carmocca enabled auto-merge (squash) March 25, 2022 12:35
@carmocca carmocca disabled auto-merge March 25, 2022 12:36
@carmocca carmocca enabled auto-merge (squash) March 25, 2022 12:36
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #12446 (7db46ab) into master (01d817c) will increase coverage by 32%.
The diff coverage is 100%.

❗ Current head 7db46ab differs from pull request most recent head 0fdf96c. Consider uploading reports for the commit 0fdf96c to get more accurate results

@@            Coverage Diff            @@
##           master   #12446     +/-   ##
=========================================
+ Coverage      56%      88%    +32%     
=========================================
  Files         215      215             
  Lines       18056    19229   +1173     
=========================================
+ Hits        10059    16901   +6842     
+ Misses       7997     2328   -5669     

@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@awaelchli awaelchli disabled auto-merge March 27, 2022 15:14
@awaelchli awaelchli enabled auto-merge (squash) March 27, 2022 15:14
@awaelchli awaelchli merged commit 7c7a4ba into Lightning-AI:master Mar 27, 2022
@adamreeve adamreeve deleted the fix_swa_stepping branch March 27, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback: swa ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants