fix library/header detection in system default paths #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py uses `compiler.has_function()` to test if a dependency exists in the system's "default paths". Unfortunately it immediately discards the result of that test. This commit fixes that and adds a corresponding output message.
avalentino
reviewed
Nov 1, 2023
| if hdrdir is True and libdir is True: | ||
| print(f"* Found {package.name} in the standard system search dirs.") | ||
| # set header dir to one of the default include dirs to fudge checks below | ||
| hdrdir = default_dirs.header[0] |
There was a problem hiding this comment.
Not totally sure that this approach is safe.
E.g. on Debian systems (and derivatives) it is possible to install the library (.so) without header files (which are normally provided in a different Debian package).
This kind of situation IMHO would result in an error at build time, and, considering that PyTables takes a while for building, it would be better to raise an error as early as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py uses
compiler.has_function()to test if a dependency exists in the system's "default paths". Unfortunately it immediately discards the result of that test. This PR fixes that and adds a corresponding output message.This has the added benefit that bzip2 detection "just works" now.