Update leaf.py #1010
Open
Update leaf.py #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid RuntimeWarning: overflow encountered in long_scalars
avalentino
reviewed
Mar 21, 2023
| @@ -316,7 +316,7 @@ def _calc_chunkshape(self, expectedrows, rowsize, itemsize): | |||
|
|
|||
| # Compute the chunksize | |||
| MB = 1024 * 1024 | |||
| expected_mb = (expectedrows * rowsize) // MB | |||
| expected_mb = np.int32((np.int64(expectedrows) * rowsize) // MB) | |||
There was a problem hiding this comment.
Sorry, I have not analysed the problem in depth but the need of a double casting looks very strange to me.
What is the data type of expectedrows normally?
In any case Python int should never be subject to overflow. Is it not enough to have a single cast to int?
There was a problem hiding this comment.
@wony-zheng could you please confirm that the following path works for you?
- expected_mb = (expectedrows * rowsize) // MB
+ expected_mb = (int(expectedrows) * rowsize) // MB)
avalentino
requested changes
May 20, 2023
| @@ -316,7 +316,7 @@ def _calc_chunkshape(self, expectedrows, rowsize, itemsize): | |||
|
|
|||
| # Compute the chunksize | |||
| MB = 1024 * 1024 | |||
| expected_mb = (expectedrows * rowsize) // MB | |||
| expected_mb = np.int32((np.int64(expectedrows) * rowsize) // MB) | |||
There was a problem hiding this comment.
@wony-zheng could you please confirm that the following path works for you?
- expected_mb = (expectedrows * rowsize) // MB
+ expected_mb = (int(expectedrows) * rowsize) // MB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid RuntimeWarning: overflow encountered in long_scalars