Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FFI definition for PyObject_AsFileDescriptor #938

Merged
merged 4 commits into from May 19, 2020
Merged

Add FFI definition for PyObject_AsFileDescriptor #938

merged 4 commits into from May 19, 2020

Conversation

thedrow
Copy link
Contributor

@thedrow thedrow commented May 18, 2020

Fixes #935.

@davidhewitt
Copy link
Member

FYI as per Gitter chat I'll review this later

@davidhewitt davidhewitt self-assigned this May 18, 2020
davidhewitt
davidhewitt requested changes May 18, 2020
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signature looks good!

Can you please also add #[cfg_attr(PyPy, link_name = "PyPyFile_AsFileDescriptor"] just above (which should be the correct symbol for PyPy)?

@thedrow
Copy link
Contributor Author

thedrow commented May 19, 2020

Done :)

@davidhewitt
Copy link
Member

Thanks - I fixed a typo (missed a closing bracket off the end, was my fault from typing my last comment on my phone yesterday 😄)

@davidhewitt
Copy link
Member

Thank you!

@davidhewitt davidhewitt merged commit 6f9048c into PyO3:master May 19, 2020
@thedrow thedrow deleted the pyfileobject-asfiledescriptor branch May 20, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@davidhewitt davidhewitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PyObject_AsFileDescriptor to fileobject FFI declarations
2 participants
@thedrow @davidhewitt