Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetPropertyValue & improve property docs #934

Merged
merged 1 commit into from May 22, 2020

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented May 17, 2020

Now that we have Clone for PyObject and Py<T>, we don't need GetPropertyValue any more, so this cleans that up.

At the same time I also:

  • Added a test for Vec<PyObject> with #[pyo3(get)] (which was broken in 0.9.2, see Generic lists #903)
  • Improved documentation for #[pyo3(get, set)].

This is all internal refactoring so I think this can be merged without blocking us from making another patch release for 0.10.x if necessary.

Closes #903

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could please add a CHANGELOG entry for this?

@davidhewitt
Copy link
Member Author

CHANGELOG added 👍

@kngwyu
Copy link
Member

kngwyu commented May 22, 2020

Thanks!

@kngwyu kngwyu merged commit 072be6c into PyO3:master May 22, 2020
@davidhewitt davidhewitt deleted the get-set-cleanups branch December 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic lists
2 participants