Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyo3-testing: initial proc_macro to make testing pyo3functions easier #4099

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

pyo3-testing: initial proc_macro to make testing pyo3functions easier #4099

wants to merge 112 commits into from

Commits on Apr 5, 2024

  1. run a quick CI on every push

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4ab7334 View commit details
    Browse the repository at this point in the history

  2. speed up tests and reduce action-minutes used

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2867622 View commit details
    Browse the repository at this point in the history

  3. remove msrv check (10min runtime)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0430023 View commit details
    Browse the repository at this point in the history

  4. remove coverage check (runtime 15 min)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5a4152f View commit details
    Browse the repository at this point in the history

  5. correctly describe what ci-quick does

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    3c1b643 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. migrate main function from sandbox

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1d772d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. resolve linting errors (clippy)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    07946d1 View commit details
    Browse the repository at this point in the history

  2. inherit workspace lints

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    963d12c View commit details
    Browse the repository at this point in the history

  3. resolve formatting issues

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    aaf7a4e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. parse import statement to a Pyo3Import

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    11cf832 View commit details
    Browse the repository at this point in the history

  2. check import path before parsing (in test)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ccaf55b View commit details
    Browse the repository at this point in the history

  3. check path and parse in dedicated function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f59e2b9 View commit details
    Browse the repository at this point in the history

  4. document the basic idea

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0b78eba View commit details
    Browse the repository at this point in the history

  5. document the expected format for pyo3import attributes

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a5627ef View commit details
    Browse the repository at this point in the history

  6. more specific function naming

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    685dce4 View commit details
    Browse the repository at this point in the history

  7. clarify how import is done

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    00553a1 View commit details
    Browse the repository at this point in the history

  8. helpful comment for future contributors

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    43ff10c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. macro test is good, import_pyo3_from not adding fn header

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    93a1614 View commit details
    Browse the repository at this point in the history

  2. adjust import_pyo3_from to take FnItem as input

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3d221e1 View commit details
    Browse the repository at this point in the history

  3. GREEN: implement the macro as a dedicated fn working on TokenStream2

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    bc3ce19 View commit details
    Browse the repository at this point in the history

  4. fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ff1fd8a View commit details
    Browse the repository at this point in the history

  5. improved naming of wrap_testcase

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    14922af View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. test multi-line blocks are correctly wrapped

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    3bf69f5 View commit details
    Browse the repository at this point in the history

  2. wrap_testcase more readable with better variable naming

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4ef1f57 View commit details
    Browse the repository at this point in the history

  3. allow mutliple imports (BROKEN: without updating everything else to u… 

    …se this)
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    372f10b View commit details
    Browse the repository at this point in the history

  4. test_wrap_testcase passing

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0d5216d View commit details
    Browse the repository at this point in the history

  5. test_wrap_testcase_multiline_block passing

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    71f07c5 View commit details
    Browse the repository at this point in the history

  6. make a TestCase struct to contain the imports and relevant bits of th… 

    …e ItemFn
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    89d050c View commit details
    Browse the repository at this point in the history

  7. GREEN: allow mutliple imports

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    866847e View commit details
    Browse the repository at this point in the history

  8. fix: fmt & clippy

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    476cb2b View commit details
    Browse the repository at this point in the history

  9. nicer (illegal) formatting

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    21c767a View commit details
    Browse the repository at this point in the history

  10. improved readability

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    aeb3d56 View commit details
    Browse the repository at this point in the history

  11. convert from ItemFn to Pyo3TestCase using From/Into

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    eccc2c5 View commit details
    Browse the repository at this point in the history

  12. ensure it works with no imports

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    9c5bc30 View commit details
    Browse the repository at this point in the history

  13. do most tests on impl_ not on wrap_testcase to remove unneccessary co… 

    …upling
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f8fe447 View commit details
    Browse the repository at this point in the history

  14. reorder code for better readability

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    9d922cf View commit details
    Browse the repository at this point in the history

  15. document the main function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    517160f View commit details
    Browse the repository at this point in the history

  16. fix docs

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4c56935 View commit details
    Browse the repository at this point in the history

  17. make pyo3test accessible via use pyo3_testing::pyo3test

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b89a976 View commit details
    Browse the repository at this point in the history

  18. add #[test] attribute to wrapped function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    75d1587 View commit details
    Browse the repository at this point in the history

  19. DONE: fix hygiene to Span::call_site, macro works correctly

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b30c7ae View commit details
    Browse the repository at this point in the history

  20. fmt & clippy

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    6d2770d View commit details
    Browse the repository at this point in the history

  21. remove unneeded allow()

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f824761 View commit details
    Browse the repository at this point in the history

  22. gate behind default feature "testing"

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    3c75653 View commit details
    Browse the repository at this point in the history

  23. add to prelude

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    5327d26 View commit details
    Browse the repository at this point in the history

  24. consistent test file naming

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    293969b View commit details
    Browse the repository at this point in the history

  25. fix clippy/x86_64-unknown-linux-gnu/beta: needless borrow

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    5b8c8bf View commit details
    Browse the repository at this point in the history

  26. add to "full" feature-set

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    59aaa8d View commit details
    Browse the repository at this point in the history

  27. fix clippy/beta: unneeded import

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a494118 View commit details
    Browse the repository at this point in the history

  28. Don't test pyo3test on GraalPy or PyPy

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    709d0df View commit details
    Browse the repository at this point in the history

  29. testing feature requires macros

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    7d9ba2d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. include pyo3-testing unittests in nox -s test-rust

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    01890d5 View commit details
    Browse the repository at this point in the history

  2. restructure for readability

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    dabfbe8 View commit details
    Browse the repository at this point in the history

  3. RED: import_module_only

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9abf88e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. match import module as well as from module import function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    af82df6 View commit details
    Browse the repository at this point in the history

  2. RED: edgecase import modulefollowed by from module import function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d75b730 View commit details
    Browse the repository at this point in the history

  3. GREEN: edgecase import modulefollowed by from module import function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ec3b80b View commit details
    Browse the repository at this point in the history

  4. fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    33a3806 View commit details
    Browse the repository at this point in the history

  5. renaming for clarity

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    fde83b0 View commit details
    Browse the repository at this point in the history

  6. if let better than single match arm

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    38c04ea View commit details
    Browse the repository at this point in the history

  7. reorder

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    63f99a1 View commit details
    Browse the repository at this point in the history

  8. simplify Parse for Pyo3Import with let functionname = match

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2ce5c87 View commit details
    Browse the repository at this point in the history

  9. improve statement ordering in wrap_testcase for better understanding

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    591eb25 View commit details
    Browse the repository at this point in the history

  10. make a PythonImportKeyword enum -> safer than strings

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ed179bb View commit details
    Browse the repository at this point in the history

  11. just use the PythonImportKeyword enum, no need for an extra struct wr… 

    …apper
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6769226 View commit details
    Browse the repository at this point in the history

  12. simplify - thankyou clippy

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4651717 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. add import_module_only integration test and fix span hygiene

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4c1fced View commit details
    Browse the repository at this point in the history

  2. leave other attributes in place if they exist

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bd67c4c View commit details
    Browse the repository at this point in the history

  3. easier way to include the test attribute

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ea0ad14 View commit details
    Browse the repository at this point in the history

  4. make conversion ItemFn -> Pyo3TestCase fallible (if args are empty or… 

    … otherwise unparsable)
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f377dc3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. handle parsing errors as compile errors

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0a1cc80 View commit details
    Browse the repository at this point in the history

  2. Complete the inline documentation

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    33e76bd View commit details
    Browse the repository at this point in the history

  3. fix whitespace in comments

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    820c211 View commit details
    Browse the repository at this point in the history

  4. first ui test passing - typo in import statement "form"

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f7ede02 View commit details
    Browse the repository at this point in the history

  5. also fail if second keyword is invalid

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    056a9c6 View commit details
    Browse the repository at this point in the history

  6. test for correct error when no import statement is provided

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    29d1f12 View commit details
    Browse the repository at this point in the history

  7. whitespace - fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6d236a3 View commit details
    Browse the repository at this point in the history

  8. test missing colon

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    939f66a View commit details
    Browse the repository at this point in the history

  9. test missing function

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f548b70 View commit details
    Browse the repository at this point in the history

  10. simplify error handling when parsing import keywords

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    918b554 View commit details
    Browse the repository at this point in the history

  11. improve error for missing colon (using peek2)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ce4d966 View commit details
    Browse the repository at this point in the history

  12. fmt: I really need to add a precommit hook ...

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a5851c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. corect testcase naming

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    59c26c5 View commit details
    Browse the repository at this point in the history

  2. add explanation of inability to ui test invalid (out of scope) pyo3me… 

    …thods or pyo3functions
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    529e2a9 View commit details
    Browse the repository at this point in the history

  3. improve error message mistyped keywords

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    0fd8167 View commit details
    Browse the repository at this point in the history

  4. fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    1836345 View commit details
    Browse the repository at this point in the history

  5. Initial guide section

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    7e5d6e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. improved variable naming in Pyo3Import::Parse

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    978c8b0 View commit details
    Browse the repository at this point in the history

  2. consistently naming variables as pyo3import(s)

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    d207bf0 View commit details
    Browse the repository at this point in the history

  3. Derive Debug, PartialEq where possible, explain where not

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    ee2847c View commit details
    Browse the repository at this point in the history

  4. Explain why not PyPy / GraalPy

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    f8dd408 View commit details
    Browse the repository at this point in the history

  5. correct internal link

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    344751a View commit details
    Browse the repository at this point in the history

  6. fix grammar and example in Testing your functionality in Rust

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    baa4c79 View commit details
    Browse the repository at this point in the history

  7. provide full rust example code in one place

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    023af31 View commit details
    Browse the repository at this point in the history

  8. Improve readability of Testing the final integration in Python

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    674a850 View commit details
    Browse the repository at this point in the history

  9. cargo expand --test test_pyo3test

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    a90919c View commit details
    Browse the repository at this point in the history

  10. unsafe {Bound::from_owned_ptr(py, py_adders::__pyo3_init())} implemen… 

    …ts ToPyObject
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    1be772f View commit details
    Browse the repository at this point in the history

  11. fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    b9b251c View commit details
    Browse the repository at this point in the history

  12. rename expanded - so fmt, clippy, test etc ignore it

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    45971fd View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. change approach to insert module directly into sys.modules

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    03adcee View commit details
    Browse the repository at this point in the history

  2. rename from py_modules to sys_modules

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6a9b754 View commit details
    Browse the repository at this point in the history

  3. fmt

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f896cb4 View commit details
    Browse the repository at this point in the history

  4. format_ident! is much nicer than string concat

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f99dbd2 View commit details
    Browse the repository at this point in the history

  5. improve readability of parse_quoted function with comments and whites… 

    …pace
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    13ce580 View commit details
    Browse the repository at this point in the history

  6. only Py>=3.9 - cannot reinitialise modules in 3.8 or lower

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3086653 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. add a comment on compatibilty with older python versions

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4173e46 View commit details
    Browse the repository at this point in the history

  2. newsfragment

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b2be6bc View commit details
    Browse the repository at this point in the history

  3. Merge: 'upstream/main' - bring fork up to date with upstream ready fo… 

    …r PR4099
    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    71f677b View commit details
    Browse the repository at this point in the history

  4. also not possible on Windows 3.9 according to impl_

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8a93c48 View commit details
    Browse the repository at this point in the history

  5. fix link in doc comment

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1cbfd1b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Remove reference to external repo

    @MusicalNinjaDad
    MusicalNinjaDad committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    373c5a2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add note that py3.9 required to run tests to avoid: 

    `ImportError: PyO3 modules compiled for CPython 3.8 or older may only be initialized once per interpreter process`
    @MusicalNinjaDad
    MusicalNinjaDad committed May 7, 2024
    Configuration menu
    Copy the full SHA
    48a29ad View commit details
    Browse the repository at this point in the history