Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deferred reference count increments and make the global reference pool optional #4095

Merged
merged 10 commits into from May 11, 2024
Merged

Remove deferred reference count increments and make the global reference pool optional #4095

merged 10 commits into from May 11, 2024

Commits on May 11, 2024

  1. Add feature controlling the global reference pool to enable avoiding … 

    …its overhead.
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    d50071b View commit details
    Browse the repository at this point in the history

  2. Document reference-pool feature in the performance guide.

    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    6a374b0 View commit details
    Browse the repository at this point in the history

  3. Invert semantics of feature to disable reference pool so the new beha… 

    …viour becomes opt-in
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    dc846ff View commit details
    Browse the repository at this point in the history

  4. Remove delayed reference count increments as we cannot prevent refere… 

    …nce count errors as long as these are available
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    df81e9a View commit details
    Browse the repository at this point in the history

  5. Adjust tests to be compatible with disable-reference-pool feature

    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    207c3d7 View commit details
    Browse the repository at this point in the history

  6. Adjust tests to be compatible with py-clone feature

    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    30daeb7 View commit details
    Browse the repository at this point in the history

  7. Adjust the GIL benchmark to the updated reference pool semantics.

    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    8e3aca6 View commit details
    Browse the repository at this point in the history

  8. Further extend and clarify the documentation of the py-clone and disa… 

    …ble-reference-pool features
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    69f5d93 View commit details
    Browse the repository at this point in the history

  9. Replace disable-reference-pool feature by pyo3_disable_reference_pool… 

    … conditional compilation flag

Such a flag is harder to use and thereby also harder to abuse. This seems
appropriate as this is purely a performance-oriented change which show only be
enabled by leaf crates and brings with it additional highly implicit sources of
process aborts.
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    2f492fd View commit details
    Browse the repository at this point in the history

  10. Add pyo3_leak_on_drop_without_reference_pool to turn aborts into leak… 

    …s when the global reference pool is disabled and the GIL is not held
    @adamreichold
    adamreichold committed May 11, 2024
    Configuration menu
    Copy the full SHA
    04f0f05 View commit details
    Browse the repository at this point in the history