Suppress non_local_definitions lint as we often want the non-local effects in macro code #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed constants instead
adamreichold
force-pushed
the
suppress-non-local-impls
branch
2 times, most recently
from
d0bcdd2
to
82efea4
Compare
…fects in macro code
adamreichold
force-pushed
the
suppress-non-local-impls
branch
from
82efea4
to
be962a2
Compare
LilyFoote
approved these changes
Apr 13, 2024
davidhewitt
pushed a commit
that referenced
this pull request
Apr 16, 2024
…fects in macro code (#4074) * Resolve references to legacy numerical constants and use the associated constants instead * Suppress non_local_definitions lint as we often want the non-local effects in macro code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.