Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_refcnt from public api #4065

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove get_refcnt from public api #4065

wants to merge 2 commits into from

Commits on Apr 10, 2024

  1. Remove get_refcnt from public api 

    This is an attempt to fix PyO3#3357.
The function is used relatively frequently in tests,
so have left it with #[cfg(test)] and pub(crate).
This avoids coating the tests with `unsafe`,
and something that doesn't indicate intent as well.

TODO:
[ ] Fix docs that refer to `get_refcnt` as an example -
    is there another function I can use instead?
    @lfn3
    lfn3 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    21ca012 View commit details
    Browse the repository at this point in the history

  2. Add newsfragment

    @lfn3
    lfn3 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5bffb27 View commit details
    Browse the repository at this point in the history