link against pythonXY_d.dll for debug Python on Windows #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @messense when testing this, I found that maturin produced abi3 builds using |
davidhewitt
force-pushed
the
debug-py-windows
branch
from
fbea29b
to
d67a8dc
Compare
|
bors r+ |
Merged
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2780
Note that upstream Python issue python/cpython#101614 means linking against
python3_d.dllis useless, so I've set this to always use the version-specific builds for now.The heuristic for detecting a Windows debug build is... not great. I check if the
EXT_SUFFIXstarts with_d., which is the only thing that I could see in the sysconfig which suggested a debug build. If this proves to be brittle, we may wish to ask upstream for something better to be added tosysconfig.