Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md #2541

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Update CHANGELOG.md #2541

merged 1 commit into from
Aug 10, 2022

Conversation

aganders3
Copy link
Contributor

I'm not sure how I messed this up merging the changelog in #2477. Sorry!

I guess chalk it up as more evidence that #2337 would be a welcome improvement.

@aganders3
Update CHANGELOG.md
b346df5 
I'm not sure how I messed this up merging the changelog in PyO3#2477. Sorry!

I guess chalk it up as more evidence that PyO3#2337 would be a welcome improvement.
davidhewitt
davidhewitt approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops - thanks! I got this number wrong first and fixed it in a later MR, probably when you rebased you picked the wrong one. My error :)

Yes definitely need to find a better CHANGELOG implementation.

@davidhewitt davidhewitt merged commit e31e27b into PyO3:main Aug 10, 2022
@aganders3 aganders3 deleted the patch-1 branch August 10, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aganders3 @davidhewitt