Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyTryFrom for PyMapping and PySequence to more accurately check types #2477

Merged
merged 15 commits into from
Aug 10, 2022
Merged

Update PyTryFrom for PyMapping and PySequence to more accurately check types #2477

merged 15 commits into from
Aug 10, 2022

Commits on Aug 9, 2022

  1. fix: update PyTryFrom for PyMapping to more accurately check for mapp… 

    …ing types
    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    511faf0 View commit details
    Browse the repository at this point in the history

  2. Register mapping class in tests/test_proto_methods::mapping

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ebf0142 View commit details
    Browse the repository at this point in the history

  3. revert setting Py_TPFLAGS_MAPPING for #[pyclass(mapping)]

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    3140ebf View commit details
    Browse the repository at this point in the history

  4. always use isinstance(<class>, collections.abs.Mapping) in try_from

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    dcfd08c View commit details
    Browse the repository at this point in the history

  5. add register_mapping_abc_subclass convenience function

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    7643f2a View commit details
    Browse the repository at this point in the history

  6. use register_mapping_abc_subclass convenience function in test_proto_… 

    …methods
    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d1630f2 View commit details
    Browse the repository at this point in the history

  7. updates from review

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    82cb926 View commit details
    Browse the repository at this point in the history

  8. Simplify name of PyMapping:register_abc_subclass

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    816918a View commit details
    Browse the repository at this point in the history

  9. Update PyTryFrom for PySequence to match subclass check used in PyMap… 

    …ping
    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    7b04aba View commit details
    Browse the repository at this point in the history

  10. Add changelog entry and migration info 

    Rebase on `main`
    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    eb87b2e View commit details
    Browse the repository at this point in the history

  11. Updates based on review 

    * Rename register_abc_subclass -> register
* Store PyResult in MAPPING_ABC and SEQUENCE_ABC statics
    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    aea20f6 View commit details
    Browse the repository at this point in the history

  12. Fix link typo in migration guide.

    @aganders3
    aganders3 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4a0a8fa View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Update guide/src/migration.md 

    Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
    @aganders3 @davidhewitt
    aganders3 and davidhewitt committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    d6a3ded View commit details
    Browse the repository at this point in the history

  2. Use map_or_else instead of chaining map and map_err

    @aganders3
    aganders3 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    3dff5ba View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pymapping-2072

    @aganders3
    aganders3 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f5907ce View commit details
    Browse the repository at this point in the history