Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup lib_name when using PYO3_CONFIG_FILE #2404

Merged
merged 4 commits into from May 29, 2022
Merged

Conversation

messense
Copy link
Member

This matches the logic in default_cross_compile:

let lib_name = if cross_compile_config.target.operating_system == OperatingSystem::Windows {
Some(default_lib_name_windows(
version,
implementation,
abi3,
false,
))
} else if is_linking_libpython_for_target(&cross_compile_config.target) {
Some(default_lib_name_unix(version, implementation, None))
} else {
None
};

@messense messense merged commit 25d2db9 into PyO3:main May 29, 2022
@messense messense deleted the fixup-lib_name branch May 29, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants