Use more robust hexadecimal escaping of interpreter configuration. #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
force-pushed
the
hex-intp-cfg
branch
2 times, most recently
from
44e9f65
to
4595237
Compare
|
@cduranti Just to verify that I understood the issue correctly, would it be possible for you to verify that this works in your setting using a Git dependency? Thank you! |
davidhewitt
approved these changes
Apr 12, 2022
Fix is working on my side, thank you very much for being so quick! |
adamreichold
force-pushed
the
hex-intp-cfg
branch
from
4595237
to
58b7081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do feel sorry for adding a hex codec to
pyo3-build-config. 馃樋Closes #2298