pyclass: mapping flag #2265
Merged
pyclass: mapping flag #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
adamreichold
reviewed
Apr 3, 2022
adamreichold
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
#[pyclass(mapping)]option, to disable the sequence-slot-flling behaviour introduced in PyO3 0.16 (#2065).This is helpful in cases where you want to implement a mapping, because having the sequence slots filled in that case is simply incorrect.
I didn't add
#[pyclass(sequence)]because the it wouldn't do anything - to implement sequence slicing the mapping slots have to be used anyway.