Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to compile with parking_lot 0.12 #2239

Merged
merged 3 commits into from Mar 22, 2022
Merged

allow to compile with parking_lot 0.12 #2239

merged 3 commits into from Mar 22, 2022

Conversation

zh-jq
Copy link

@zh-jq zh-jq commented Mar 21, 2022

No description provided.

@messense
Copy link
Member

Hmm, I'm not of ideas, even with --lock --frozen --offline it still updates the lockfile to use latest version of parking_lot in the setuptools-rust example.

@adamreichold
Copy link
Member

Hmm, I'm not of ideas, even with --lock --frozen --offline it still updates the lockfile to use latest version of parking_lot in the setuptools-rust example.

I think the problem is that the cargo update --precise steps will crate a Cargo.lock in the repository root, i.e. for the pyo3 crate. This is sufficient for its compile tests which where the only ones which needed it for now as the downgraded dependencies are optional and the examples do not use them. But parking_lot is not optional and hence I suspect that we would need to create a lock file for each of the examples.

@messense
Copy link
Member

@adamreichold Thanks! Made it work in 8108dfc.

Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is alright without a CHANGELOG entry as it is not a public dependency.

@davidhewitt
Copy link
Member

I think this is alright without a CHANGELOG entry as it is not a public dependency.

I quite like noting the version bump anyway. Did parking_lot change msrv? That may affect which PyO3 versions can compile without cargo update tweaks.

@messense
Copy link
Member

@messense messense merged commit 4339214 into PyO3:main Mar 22, 2022
@messense
Copy link
Member

Thank you @zh-jq !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants