Added an as_bytes method for Py<PyBytes> #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test is a network flake, can someone rerun those builds? |
mejrs
requested changes
Mar 19, 2022
This allows for obtaining a slice that's not lexically bound to the GIL which can be helpful to avoid copying.
davidhewitt
approved these changes
Mar 19, 2022
There was a problem hiding this comment.
Looks reasonable to me, thanks!
I think there's a few other immutable types like str and tuple which I guess can also have treatment like this where py is necessary for reading, but once read, the GIL can be released. Might be interesting to follow up this another time.
|
Yes, I'm sure there's other cases where this pattern would be helpful -- I send this particularly because I have a use case in pyca/cryptography for this, where we'll be able to optimize some code to avoid allocations/copying now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.